Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix undo/redo history when inserting a link configured to open in a new tab #50460

Merged
merged 14 commits into from
May 24, 2023
Merged

[RNMobile] Fix undo/redo history when inserting a link configured to open in a new tab #50460

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c908c06
Add rel to link formatting attributes
derekblank May 9, 2023
ccef5a6
Update CHANGELOG to add undo/redo fix to Unreleased section
derekblank May 10, 2023
2afa3e1
Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his…
derekblank May 10, 2023
f9dc5b2
Merge trunk
derekblank May 10, 2023
404e209
Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his…
derekblank May 11, 2023
74236fb
Update packages/react-native-editor/CHANGELOG.md
derekblank May 11, 2023
b4816ce
Update packages/react-native-editor/CHANGELOG.md
derekblank May 15, 2023
602f8a9
Add test for checking undo/redo history when a link is configured to …
derekblank May 22, 2023
1726663
Update link settings modal test case to check for correct editor history
derekblank May 22, 2023
da58ff4
Merge branch 'rnmobile/fix/undo-redo-history' of https://github.com/W…
derekblank May 22, 2023
0124f67
Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his…
derekblank May 22, 2023
997f8d6
test: Fix React prop typo
dcalhoun May 22, 2023
87dcd92
test: Simplify test queries
dcalhoun May 22, 2023
d0098e6
test: Increase editor history link test accuracy
dcalhoun May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/format-library/src/link/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const link = {
attributes: {
url: 'href',
target: 'target',
rel: 'rel',
},
edit: withSpokenMessages(
class LinkEdit extends Component {
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ For each user feature we should also add a importance categorization label to i
- [*] Fix crash when trying to convert to regular blocks an undefined/deleted reusable block [#50475]
- [**] Tapping on a nested block now gets focus directly instead of having to tap multiple times depeding on the nesting levels. [#50108]
- [*] Use host app namespace in reusable block message [#50478]
- [**] Fix bug affecting undo and redo history when instering a link configured to open in a new tab [#50460]
derekblank marked this conversation as resolved.
Show resolved Hide resolved

## 1.94.0
- [*] Split pasted content between title and body. [#37169]
Expand Down