Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Fix undo/redo history when inserting a link configured to open in a new tab #50460

Merged
merged 14 commits into from
May 24, 2023
Merged

[RNMobile] Fix undo/redo history when inserting a link configured to open in a new tab #50460

merged 14 commits into from
May 24, 2023

Commits on May 9, 2023

  1. Add rel to link formatting attributes

    @derekblank
    derekblank committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c908c06 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Update CHANGELOG to add undo/redo fix to Unreleased section

    @derekblank
    derekblank committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ccef5a6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his… 

    …tory
    @derekblank
    derekblank committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2afa3e1 View commit details
    Browse the repository at this point in the history

  3. Merge trunk

    @derekblank
    derekblank committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f9dc5b2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his… 

    …tory
    @derekblank
    derekblank committed May 11, 2023
    Configuration menu
    Copy the full SHA
    404e209 View commit details
    Browse the repository at this point in the history

  2. Update packages/react-native-editor/CHANGELOG.md 

    Co-authored-by: Tanner Stokes <tanner.stokes@automattic.com>
    @derekblank @twstokes
    derekblank and twstokes committed May 11, 2023
    Configuration menu
    Copy the full SHA
    74236fb View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Update packages/react-native-editor/CHANGELOG.md 

    Co-authored-by: David Calhoun <github@davidcalhoun.me>
    @derekblank @dcalhoun
    derekblank and dcalhoun committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b4816ce View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Add test for checking undo/redo history when a link is configured to … 

    …open in a new tab
    @derekblank
    derekblank committed May 22, 2023
    Configuration menu
    Copy the full SHA
    602f8a9 View commit details
    Browse the repository at this point in the history

  2. Update link settings modal test case to check for correct editor history

    @derekblank
    derekblank committed May 22, 2023
    Configuration menu
    Copy the full SHA
    1726663 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'rnmobile/fix/undo-redo-history' of https://github.com/W… 

    …ordPress/gutenberg into rnmobile/fix/undo-redo-history
    @derekblank
    derekblank committed May 22, 2023
    Configuration menu
    Copy the full SHA
    da58ff4 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin' into rnmobile/fix/undo-redo-his… 

    …tory
    @derekblank
    derekblank committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0124f67 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. test: Fix React prop typo

    @dcalhoun @derekblank
    dcalhoun authored and derekblank committed May 23, 2023
    Configuration menu
    Copy the full SHA
    997f8d6 View commit details
    Browse the repository at this point in the history

  2. test: Simplify test queries 

    The targeted elements do not require asynchronous queries. Using
synchronous queries is more concise and easier to comprehend.
    @dcalhoun @derekblank
    dcalhoun authored and derekblank committed May 23, 2023
    Configuration menu
    Copy the full SHA
    87dcd92 View commit details
    Browse the repository at this point in the history

  3. test: Increase editor history link test accuracy 

    The targeted bug occurs when:

1. Changing a link to "Open in a new tab."
2. Performing additional changes, e.g. typing.
3. Undoing both actions.
4. Redoing both actions.

Thus, this changes the initial HTML, adds additional undo/redo
invocations, and updates inline snapshots to match the expected
outcomes.
    @dcalhoun @derekblank
    dcalhoun authored and derekblank committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d0098e6 View commit details
    Browse the repository at this point in the history