Update full screen modal dimensions, and pattern grids #49894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new radius coming well into its own here 👍 👍 Thanks for the detailed before/after's. I'm with you all the way until the preferences modal. Indeed I think that's an opportunity to discuss defaults here. In general, modal is definitely meant to grab your attention, so I personally think it's okay to go really huge by default. But I also think that it's useful to override that modal width/height on a per-modal basis. The commandbar comes to mind as one example, it should definitely not be fullscreen. The preferences dialog as well. For me, that dialog is mostly about ensuring legibility, so I would keep the existing width/height combo there, or at least something like it. |
|
Size Change: -121 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4a9e2ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4745104779
|
|
Yes I thought that one might be contentious. I'll revert. |
apeatling
approved these changes
Apr 18, 2023
|
Lovely work @jameskoster ! |
bph
added
[Feature] Patterns
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR does a couple of things.
Why?
How?
isFullScreenprop to severalModalinstances.isFullScreencss.Testing Instructions
Open any full screen modal:
Screenshots or screencast
Pattern directory
Note the equal spacing around the entire modal.
Choose a template part
Choose a query pattern
Preferences