Increase dimensions of the pattern modal that appears when creating a new page #49859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +52 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
I personally think this is good. No reason not to let you have space. Perhaps a teensy bit smaller? I wonder if we couldn't get a cleaner grid if instead of percentage widths, you just set width and heights to 100%, then added an inner padding instead? Something like 72px, that range? |
The dimensions are the same as the add-template modal. I think it makes sense for them to be equal, so we can try different sizes together once this is merged.
I'm struggling to picture what you mean 🤔 feel free to push directly to the branch if you'd like to try something. |
I'm ashamed to ask this question, I should know better: where do you see the "new page" modal? When I click to add a new page, I'm not seeing it. But to describe better, right now the modal is 95% tall, and 95% wide, which means the modal will have the same aspect ratio as the viewport. Looking at the code, it looks like this is actually what the mobile breakpoint does, more or less: I guess I'm suggesting doing something similar for larger breakpoints, e.g. Mainly I just think it might feel more app-like, if the modal was always the same direction from the edge as you resized the viewport. What do you think? |
|
Oh you're referring to the modal itself, now it makes sense. Since you mentioned grid I thought you meant the patterns :) I'll give it a try.
You need to have some patterns associated with the Post Content block. Here's an example: |
|
Good intuition, this does seem better! patterns.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49722.
What?
Increases the dimensions of the modal that displays full-page patterns when creating a new page:
patterns.mp4
I retained the 'masonry' layout because full-page patterns may not necessarily be long.
Why?
The current version feels a bit cramped:
How?
CSS.
Testing Instructions
For the modal to appear there needs to be patterns associated with the Post Content block.