Move copy and pasting styles menu items to a separate menu group #47430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +52 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e180b7c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4009244323
|
jasmussen
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Good change. The before image below is not very clear about the feature-set, that you can copy and paste styles:
This after image below is much clearer that you can both copy blocks, or copy styles. Yes, the copy action might technically be the same, but the actual feature becomes much clearer for it:
There's a future followup of improving this menu further, in terms of leveraging flyouts for a couple of actions when possible. But in lieu of that, this is a stronger starting point, even if the menu becomes taller. Nice work!
ndiego
approved these changes
Jan 26, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #47164 by adding a MenuGroup with "Copy styles" and "Paste styles" within and removing the standalone "Copy styles" MenuItem.
Technically, "Copy styles" and "Copy block" are the same functionality, but having a separate control for copying styles makes this more discoverable.
Why?
Makes the copy/pasting of styles more discoverable, as in the current state copying styles is undiscoverable.
Testing Instructions
The functionality has not changed, just the presentation.
Screenshots or screencast
CleanShot.2023-01-25.at.14.18.23.mp4