Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer controls for copying and pasting styles #47164

Closed
richtabor opened this issue Jan 15, 2023 · 6 comments · Fixed by #47430
Closed

Clearer controls for copying and pasting styles #47164

richtabor opened this issue Jan 15, 2023 · 6 comments · Fixed by #47430
Assignees
Labels
[Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

Now that we have the functionality in place for copying and pasting block styles, let's follow-up with some approaches for making the functionality more apparent. (Related: #45477 (comment))

In its current form, it is not clear that one can copy the current block's style. "Copy block" should continue to function as it does today, where it copies block and styles.

What is your proposed solution?

Here are some rough concepts based on the discussion on the original PR to get us moving.

Current:

Here's the current implementation for reference. The "Copy block" control functions as both copying the block as as whole, or styles, based on the paste follow-up action.

CleanShot 2023-01-14 at 19 35 48@2x

Suggestion 1:

Add a section within the popover, with Copy styles and Paste styles in it directly. It could go at the bottom of the popover instead.

CleanShot 2023-01-14 at 19 36 38@2x

Suggestion 2:

Add a popover interaction. If we did this, we can afford to have both copy and paste, for block (which is the entire block, as-is - including styles) or just styles.

CleanShot 2023-01-14 at 19 37 29@2x

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. labels Jan 15, 2023
@jasmussen
Copy link
Contributor

I agree, there are some slightly similar iterations in the original issue: #44418

@ndiego
Copy link
Member

ndiego commented Jan 20, 2023

+1 on this. The functionality is insanely useful, but it's not very clear that "Copy block" then allows you to "Paste Styles".

I wonder if simply removing "block" from "Copy block" helps. We don't have "block" in the "Duplicate" label.

@richtabor
Copy link
Member Author

I agree, there are some slightly similar iterations in the original issue: #44418

@jasmussen @jameskoster Which direction are you leaning?

@jasmussen
Copy link
Contributor

I prefer the flyout for compactness, but that requires a new flyout component structure which is likely non trivial to build, so in lieu of that, grouping with a separator can work in the mean time.

@jameskoster
Copy link
Contributor

+1 for the flyout. I wonder if we could streamline a bit if we grouped by action, IE:

COPY
Block
Styles

PASTE
Block
Styles

@richtabor
Copy link
Member Author

richtabor commented Jan 25, 2023

a new flyout component structure which is likely non trivial to build

Agreed.

I'm good if we roll with adding a grouped section for "Copy styles" and "Paste styles" for now, and iterate towards a flyout later.

CleanShot 2023-01-14 at 19 36 38@2x

@richtabor richtabor added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jan 25, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 25, 2023
@richtabor richtabor moved this to 🏗️ In Progress in WordPress 6.2 Editor Tasks Jan 25, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.2 Editor Tasks Jan 26, 2023
@richtabor richtabor moved this from 🔎 Needs Review to ✅ Done in WordPress 6.2 Editor Tasks Jan 26, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants