Allow resizing the sidebar in the site editor using keyboard #47176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
jasmussen
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Outstanding, the tests haven't even passed on the complementary #47138 and this is already in the can:
By the way, it would be cool to consider adding snap points for this particular handle, I suspect complete freeform resizing isn't necessarily as convenient as a couple of specific points. CC: @jameskoster @SaxonF
|
Size Change: +80 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
fix/arrow-key-resizing
branch
from
9418c1b to
0654534
Compare
|
Flaky tests detected in 0654534. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3929228386
|
Mamaduka
added
the
[Feature] Site Editor
annezazu
added
[Focus] Accessibility (a11y)
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a callback to the resize handle in the site editor to allow resizing the sidebar using keyboard (arrow keys).
Testing Instructions