Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse mode: resize drag handle does not have keyboard support #47336

Closed
joedolson opened this issue Jan 23, 2023 · 4 comments
Closed

Browse mode: resize drag handle does not have keyboard support #47336

joedolson opened this issue Jan 23, 2023 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@joedolson
Copy link
Contributor

Description

The drag handle to resize the navigation and editor panes in full site editing is focusable and labeled appropriately, but does not respond to arrow key presses to adjust sizing. If they are controlled by a key other than arrow keys, that needs to be communicated; but I'd also consider that to be a strange choice.

Step-by-step reproduction instructions

  1. Go to Site Editing
  2. Select 'Manage All Templates' to set focus position at end of navigation pane.
  3. Press tab to reach the drag handle.
  4. Attempt to adjust the pane sizes using arrow keys.

Screenshots, screen recording, code snippet

No response

Environment info

Gutenberg 15

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@joedolson joedolson added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [a11y] Keyboard & Focus labels Jan 23, 2023
@annezazu annezazu changed the title Full Site Editor resize drag handle does not have keyboard support Browse mode: resize drag handle does not have keyboard support Jan 23, 2023
@annezazu
Copy link
Contributor

cc @youknowriad as a heads up!

@Mamaduka
Copy link
Member

Probably resolved by #47176.

@youknowriad
Copy link
Contributor

Yes this has been solved. I'm closing the issue, let me know if there's anything missing.

@joedolson
Copy link
Contributor Author

So many very similar words, and yet I didn't find it. I'll admit, I wasn't aware that I would need to also search pull requests that may not be associated with an issue. Glad this is handled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

5 participants