Update push changes to global styles label text to "apply globally" #46965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
andrewserong
changed the title
|
Size Change: +1.83 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c444213. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3888008847
|
|
I've no issues with it. cc. @jasmussen for his thoughts as he worked on the design of this feature. Another suggestion was to make the button read "Apply to all Heading blocks". (Heading would be replaced with the selected block.) I think it might have caused issues with overflowing text though. What do you think? |
|
Thanks for taking a look!
Oh, that's a good point, I see from your discussion with Ramon that the button looks a bit busy if it winds up being forced to wrap: #46446 (comment) Happy to go with whatever folks, like, though... let's see what the designers think! |
|
I think it's best to keep the button label short, especially since the help text beneath describes the full behaviour. For the Snackbar, perhaps we can go even shorter: "Button styles updated". What do you think? |
juanfra
reviewed
Jan 9, 2023
| @@ -137,7 +137,7 @@ function PushChangesToGlobalStylesControl( { | |||
| disabled={ changes.length === 0 } | |||
| onClick={ pushChanges } | |||
| > | |||
| { __( 'Push changes to Global Styles' ) } | |||
| { __( 'Apply globally' ) } | |||
There was a problem hiding this comment.
Looking great!
We may also want to update the description (line 127) as discussed here
|
Thanks for the feedback, folks! I've updated the help text to use "Apply" instead of "Move", and updated the snackbar notification to say "{block} styles updated." Here's how it's looking now:
Let me know if you want any other changes! 🙂 |
|
I made a small change to my own suggestion :) The Snackbar now reads: "Button styles applied." This harmonizes with the language in the button / description, and hopefully eliminates any confusion as to whether those changes have been saved or not. |
jameskoster
approved these changes
Jan 10, 2023
|
Thanks for updating this one @jameskoster! I've just updated the text in the e2e test to match, and will merge this in once the tests pass 🙂 |
noisysocks
approved these changes
Jan 10, 2023
andrewserong
deleted the
update/push-changes-to-global-styles-label-text
branch
|
Nice one! |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46928
Renames "Push changes to global styles" to "Apply globally" at the block level in the site editor.
Why?
As raised in #46928, this avoids referring to Global Styles as a proper noun, and instead the label text describes the action.
How?
Testing Instructions
Screenshots or screencast
The snackbar notification text is also updated: