-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming "Push changes to Global Styles" #46928
Comments
@jameskoster since these were based on your designs do you know if it is agreed upon to use the "Global Styles" name? In my mind, I think we should stick with Styles due to precedence in the interface, welcome guide, etc. |
I like this idea, and "Push changes globally" has a nice ring to it to me — instead of using a proper noun, it describes the action, which I quite like for buttons. Happy to throw up a quick PR on Monday if we have agreement on what the label should be. |
I dig that. While we're looking at this, does the style of the button itself match what we'd normally use? It feels like a very prominent style for a potentially less often used feature under Advanced settings. |
We can probably explore that separately, after we've determined whether the Appearance / Settings inspector tabs experiment has been successful. If so it might make more sense to include this in the Appearance tab. Another thing to consider is resetting custom styles, which is an action very closely related to this one. A very rough mockup: |
Oh, I like that, too. I've thrown up a quick PR to do the renaming in #46965. |
Nicely done 👏 I see that on @jameskoster's proposal, the description is also changing to start with "Apply this block's...". Do we also want to update that? I'd be happy to open a tiny PR with that. |
@juanfra I think it might be worth it since "Move" is a little bit ambiguous. |
Hi @annezazu, thanks for the ping!
^ This works and feels clear as a label for the button. @juanfra said:
For that microtext, I see just one small grammar issue to fix: Currently reads:
Should read:
|
Thank you, Krista! I just double-checked the code and the apostrophe is in place, so we're safe there. I left a comment on Andrew's PR to address the update of the microtext. |
Thank you all for diving right in with design, editorial, and dev work. Love it. |
How do we determine this?
Agreed, although likely a tad tricky. |
I'm not actually sure :) |
What problem does this address?
In 14.9, a new feature was added to push changes to global styles:
Global Styles is the name of broader effort though than just the exposed Styles UI in my opinion: #41232 Generally speaking, saying "Global styles" is something that has been avoided in user docs because of this reason.
What is your proposed solution?
Rename this to "Push changes to Styles" or "Push changes globally".
The text was updated successfully, but these errors were encountered: