Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming "Push changes to Global Styles" #46928

Closed
annezazu opened this issue Jan 6, 2023 · 13 comments · Fixed by #46965
Closed

Consider renaming "Push changes to Global Styles" #46928

annezazu opened this issue Jan 6, 2023 · 13 comments · Fixed by #46965
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jan 6, 2023

What problem does this address?

In 14.9, a new feature was added to push changes to global styles:

Screen Shot 2023-01-05 at 8 50 40 PM

Global Styles is the name of broader effort though than just the exposed Styles UI in my opinion: #41232 Generally speaking, saying "Global styles" is something that has been avoided in user docs because of this reason.

What is your proposed solution?

Rename this to "Push changes to Styles" or "Push changes globally".

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. labels Jan 6, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Jan 6, 2023

@jameskoster since these were based on your designs do you know if it is agreed upon to use the "Global Styles" name? In my mind, I think we should stick with Styles due to precedence in the interface, welcome guide, etc.

@andrewserong
Copy link
Contributor

I like this idea, and "Push changes globally" has a nice ring to it to me — instead of using a proper noun, it describes the action, which I quite like for buttons. Happy to throw up a quick PR on Monday if we have agreement on what the label should be.

@jameskoster
Copy link
Contributor

I don't think it was discussed at all. I agree this label is probably a bit technical, perhaps even the "push" part as well?

Is "Apply" better than "push"? 🤔

Screenshot 2023-01-06 at 12 05 29

@annezazu annezazu added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jan 6, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Jan 6, 2023

I dig that. While we're looking at this, does the style of the button itself match what we'd normally use? It feels like a very prominent style for a potentially less often used feature under Advanced settings.

@jameskoster
Copy link
Contributor

We can probably explore that separately, after we've determined whether the Appearance / Settings inspector tabs experiment has been successful. If so it might make more sense to include this in the Appearance tab.

Another thing to consider is resetting custom styles, which is an action very closely related to this one. A very rough mockup:

Screenshot 2023-01-06 at 17 13 23

@andrewserong
Copy link
Contributor

Is "Apply" better than "push"?

Oh, I like that, too. I've thrown up a quick PR to do the renaming in #46965.

@juanfra
Copy link
Member

juanfra commented Jan 9, 2023

Nicely done 👏

I see that on @jameskoster's proposal, the description is also changing to start with "Apply this block's...". Do we also want to update that? I'd be happy to open a tiny PR with that.

@jameskoster
Copy link
Contributor

@juanfra I think it might be worth it since "Move" is a little bit ambiguous.

@kristastevens
Copy link

Hi @annezazu, thanks for the ping!

Apply globally

^ This works and feels clear as a label for the button.

@juanfra said:

I see that on....proposal, the description is also changing to start with "Apply this block's...". Do we also want to update that? I'd be happy to open a tiny PR with that.

For that microtext, I see just one small grammar issue to fix:

Currently reads:

Apply this blocks typography, spacing, dimensions, and color styles to all Heading blocks.

Should read:

Apply this block's typography, spacing, dimensions, and color styles to all Heading blocks.

@juanfra
Copy link
Member

juanfra commented Jan 9, 2023

Thank you, Krista! I just double-checked the code and the apostrophe is in place, so we're safe there.

I left a comment on Andrew's PR to address the update of the microtext.

@annezazu
Copy link
Contributor Author

annezazu commented Jan 9, 2023

Thank you all for diving right in with design, editorial, and dev work. Love it.

@richtabor
Copy link
Member

We can probably explore that separately, after we've determined whether the Appearance / Settings inspector tabs experiment has been successful.

How do we determine this?

If so it might make more sense to include this in the Appearance tab.

Agreed, although likely a tad tricky.

@jameskoster
Copy link
Contributor

How do we determine this?

I'm not actually sure :)

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants