Fix Nav Submenu block Link UI text control #46243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
reviewed
Dec 1, 2022
getdave
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Screen.Capture.on.2022-12-01.at.19-09-18.mov
Thanks for solving this one. We just need to strip the HTML as shown in this video.
That functionality isn't a default part of link control because not all values that are passed in are HTML but maybe it should be...?
I feel like it should be. I'll open up a follow-up to this PR to tackle that though. For now I've done the same thing as in UPDATE: Added in #46263 |
getdave
approved these changes
Dec 2, 2022
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Add hasTextControl to submenu LinkControl
* Clean up unnecessary prop={ true } in submenu LinkControl
* Add JSDoc for hasTextConrtol prop to LinkControl
* Fix missing label in dropdown
* Use stripHTML for the title/label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the text control to the navigation submenu link ui to match the normal navigation link ui.
Why?
Fixes #46206
How?
Adds the
hasTextControlprop to the<LinkControl>component.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After