Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Submenu block Link UI text control #46206

Closed
getdave opened this issue Nov 30, 2022 · 0 comments · Fixed by #46243
Closed

Nav Submenu block Link UI text control #46206

getdave opened this issue Nov 30, 2022 · 0 comments · Fixed by #46243
Assignees
@ajlende
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation

Comments

@getdave
Copy link
Contributor

getdave commented Nov 30, 2022

I noticed that Submenu block's dont' seem to activate the Text control portion of the Link UI. This should be achievable by passing in the hasTextControl prop to <LinkControl> and also ensuring the label prop is set on the the link value that is passed to <LinkControl>.

The core/navigation-link block does this.
@getdave getdave added the [Block] Submenu Affects the Submenu Block - for submenus in navigation label Nov 30, 2022
@scruffian scruffian mentioned this issue Dec 1, 2022
Closed
32 tasks
@ajlende ajlende self-assigned this Dec 1, 2022
@ajlende ajlende mentioned this issue Dec 1, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 1, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajlende ajlende

Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Nav Submenu block Link UI text control WordPress/gutenberg
3 participants
@getdave @ajlende @priethor