PluginSidebar: show pin/unpin button on the site eitor #46067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -54 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
t-hamano
added
[Feature] Plugins API
t-hamano
force-pushed
the
edit-site/show-pin-unpinned-button
branch
from
f729ad4 to
c1e0762
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Since I have submitted #61448, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR displays the pin/unpin button of the
PluginSidebarthat was hidden in the site editor. This will allow pinning/unpinning of the plugin sidebar button as well as in the post editor.Why?
From what I could find, initially the button was temporarily hidden in #21260 because there was no way to display unpinned sidebar items in the site editor. However, #34460 added plugin support in the site editor as well, and unpinned plugins should be able to be viewed from the options menu.
How?
Just removed the CSS that hides the button.
Testing Instructions
Use the following code to display the plugin sidebar:
Screenshots or screencast
ef4c562c4985fe5599b899a18e4d09a5.mp4