Chore: Fix: Hide pin-unpin button from edit-site sidebar #21260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
force-pushed
the
fix/hide-pin-unpin-button-from-edit-site
branch
from
d504121 to
6bdd16d
Compare
jorgefilipecosta
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: +81 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/hide-pin-unpin-button-from-edit-site
branch
from
6bdd16d to
d314d4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #20698.
Currently, in interface/edit-site we did not implement yet a system to shown unpinned sidebar items. Adding that into #20698 would make the PR even bigger.
But that causes a problem if the user unpins an item from edit-site there is no way to open it again. This PR proposes a temporary solution: hiding the button to unpin an item from edit-site. This temporary solution should be removed when edit-site/interface gets the ability to show unpinned sidebar items.
How has this been tested?
I verified there was no way to unpin global styles and block inspector sidebars from edit-site.