Performance global styles WP_Query

[spacedmonkey]

What?

Fixes #45978

Disable priming of post meta and terms for in global styles WP_Query. This saves two database queries in FSE themes.

Why?

How?

Testing Instructions

Screenshots or screencast

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[spacedmonkey]

The to_array method of WP_Post, does some weird stuff that loads terms and meta. We dont need this data here. So let's use get_object_vars instead.

[felixarntz]

@spacedmonkey Great, this looks excellent.

Should we address this in core too, or will this change here cover for it on its own?

[ocean90]

The diff against the version in WordPress core:

@@ -34,15 +34,17 @@
 		$user_cpt         = array();
 		$post_type_filter = 'wp_global_styles';
 		$stylesheet       = $theme->get_stylesheet();
-		$args             = array(
-			'posts_per_page'      => 1,
-			'orderby'             => 'date',
-			'order'               => 'desc',
-			'post_type'           => $post_type_filter,
-			'post_status'         => $post_status_filter,
-			'ignore_sticky_posts' => true,
-			'no_found_rows'       => true,
-			'tax_query'           => array(
+		$args = array(
+			'posts_per_page'         => 1,
+			'orderby'                => 'date',
+			'order'                  => 'desc',
+			'post_type'              => $post_type_filter,
+			'post_status'            => $post_status_filter,
+			'ignore_sticky_posts'    => true,
+			'no_found_rows'          => true,
+			'update_post_meta_cache' => false,
+			'update_post_term_cache' => false,
+			'tax_query'              => array(
 				array(
 					'taxonomy' => 'wp_theme',
 					'field'    => 'name',
@@ -54,7 +56,7 @@
 		$global_style_query = new WP_Query();
 		$recent_posts       = $global_style_query->query( $args );
 		if ( count( $recent_posts ) === 1 ) {
-			$user_cpt = get_post( $recent_posts[0], ARRAY_A );
+			$user_cpt = get_object_vars( $recent_posts[0] );
 		} elseif ( $create_post ) {
 			$cpt_post_id = wp_insert_post(
 				array(
@@ -70,7 +72,7 @@
 				true
 			);
 			if ( ! is_wp_error( $cpt_post_id ) ) {
-				$user_cpt = get_post( $cpt_post_id, ARRAY_A );
+				$user_cpt = get_object_vars( get_post( $cpt_post_id ) );
 			}
 		}

[ocean90]

Not sure if we really have to return all post fields via get_object_vars() or if should just limit it to the ID and post_content fields since nothing else is used. Aside from the failing tests, this is looking good.

Note that there's a related chat on Slack on whether this is the correct file to patch or not. cc @ockham

[spacedmonkey]

Not sure if we really have to return all post fields via get_object_vars() or if should just limit it to the ID and post_content fields since nothing else is used. Aside from the failing tests, this is looking good.

I think we fix this that in another PR. This ticket fixes the core issue, we can tweak it elsewhere.

[aristath]

Great improvement! Thank you @spacedmonkey for spotting this 👍

The code makes sense and works as advertised.