Try: Tab style subpixel fix. #42892
Merged
Try: Tab style subpixel fix. #42892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +7 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #40998 which beautifully reduced the weight of the active tab style. There was a subpixel alignment issue on the active tab in the sidebar only, which this PR hopes to fix.
Before:
After:
How?
It's unclear exactly why the button height is a half pixel less tall inside the sidebar compared to the inserter, but as best I can tell it's a rounding math issue.
This PR sets
content-boxon the tabbox container instead, and an explicit height that omits the bottom 1px border, which appears to solve it.Testing Instructions
Test any tab in the interface and check no visual regressions.