Reduce active tab accent weight #40998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
General Interface
I don't even mind 1px, though I acknowledge it may be a step too far :)
|
|
Size Change: +487 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Nice! |
|
@beafialho pointed out that 1.5px can work well, and match other focus outlines. |
Merged
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reduces the visual weight of the active state in the tab component.
Why?
Staring at #40204 and the concepts therein I noticed how heavy the Inspector can feel sometimes. This adjustment feels like an improvement that can go hand-in-hand with other efforts to streamline the UI.
2px is used so that the active tab is still visible when you focus (focus has a 1.5px outline). But it would be easier to try different values and add a dedicated style for active + focussed.
How?
Adjusted css properties of
components-button components-tab-panel__tabs-item.is-active.Testing Instructions
Peruse any UI region that makes use of tabs, e.g. the Inspector or the Inserter(s).
Before
After