Only allow template part to be replaced if its a header or footer #40787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +365 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
If possible I would suggest using the template area instead of the tag name. |
|
Good point, I'll push an update. |
carolinan
approved these changes
May 12, 2022
Mamaduka
approved these changes
May 12, 2022
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the 'Replace' flow is enabled for all template part types. But it's only really useful for semantically related template parts, IE enabling the replacement of one header with another. For general template parts it's much less useful.
This PR updates the logic so that it's only possible for template parts assigned to the
headerorfooterarea to be replaced.We might consider re-enabling this in the future if the replace modal is searchable.
Before
before.mp4
After
after.mp4
To test