Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the 'Replace' affordance on generic template parts #39797

Closed
jameskoster opened this issue Mar 28, 2022 · 0 comments · Fixed by #40787
Closed

Disable the 'Replace' affordance on generic template parts #39797

jameskoster opened this issue Mar 28, 2022 · 0 comments · Fixed by #40787
Labels
[Block] Template Part Affects the Template Parts Block

Comments

@jameskoster
Copy link
Contributor

The 'replace' affordance on template parts makes it easy to quickly swap out one header (or footer) for another:

Screenshot 2022-03-28 at 10 41 23

It's much less useful when the template part has no assigned area. For example in my theme I have a content.html template part that I use in various query loops. When I click 'replace' in the editor I'm presented with all existing template parts, including things like headers and footers:

Screenshot 2022-03-28 at 10 43 17

That "Choose a general" heading in the modal is especially strange :D

I propose that we disable this functionality altogether for generic template parts. It just seems very difficult to populate the modal with relevant suggestions when there is no semantic area assigned to the template part. I would never replace my content.html template part with header.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant