Add a Background Image Block Support and opt-in for the Group block #39243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Block] Group
8 tasks
|
Size Change: +809 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Appreciate your passion here, and I know @getdave does too! We want background options for the group block. From the conversation on the other PR/issue, though, it remains important that we get the design right. @javierarce is currently working on a design for it, and we hope to have something to share very soon! |
|
Thanks @jasmussen! This draft is very much just me hacking around to get a better idea of how we might (potentially) implement it from a technical angle, so I'm very happy to leave this PR in a draft state as we experiment with that part, and leave the polishing phase / finessing to once we've got some designs 🙂 |
|
Wanted to mention a new ticket with a design for a single "Background" panel in #39427. It also features layers, but there are mockups for a more near term solution as well. |
|
I just wanted to extend an offer to pair with you on this PR if you'd like to start with some of the ideas we have from #39427 (comment). At your convenience of course, I imagine there may be other things on your plate! |
|
Oh, thank you @jasmussen, much appreciated! I'm actually a little busy focusing primarily on style engine work (#38167) for the next little while before I go AFK, so I might not have a chance to delve into this much deeper in the shorter-term. If anyone else wants to pick up the work in the mean-time, feel free to grab anything from this PR in case it's helpful for looking at one way to implement the block support. Otherwise, I'd be happy to dig in a little further down the track 🙂 I'm very pleased we've got a solid direction forward in #39427, though, thanks for the work there between you and @javierarce! |
3 tasks
|
Hey @andrewserong As there are various explorations going on with design tools. I am curious how Background Image block support is coming along? Thank you! I noticed recently that it is tricky to add a background image to the header area in Full Site Editing, so I am hoping this gets sorted out. We also need to make sure that the padding/margin above the header is easily removed through the dimension setting. As the white background shines through above the Header. |
|
Thanks for the ping @paaljoachim! I'm travelling for the next week or two, so can't follow-up on this one immediately, but I'd love to see a background / background image block support get put in place at some point (I'd be keen to see it output at the root level for a site-wide background image too). In the nearer-term, my focus will be on helping out with some of the other issues that were prioritised for phase 2 in this issue: #33094 — I'm mostly focused on improvements to the Layout block support, and a number of dependency tasks / features that form part of the sticky / fixed positioning issue. However, within the phase 2 tracking issue, there is also the Design Tools Overview issue (#33447) which also specifies the background tools issue (#16479) that relates to this PR. I just thought I'd mention those linked issues in case any of those already cover the cases you have in mind? I'd love to get back to this PR eventually, but as it is unlikely to be very soon, if anyone else would like to pick up this task in the meantime, feel free to grab / borrow anything of use from here. If no-one beats me to it, then when I'm back in a couple of weeks, I'd like to at least see if I can give this PR a fresh rebase so that it's still a decent discussion point (with the context that the earlier discussion for this PR resulted in the idea of pursuing a separate Background panel, which still needs to be explored in code, I believe). Hope that helps! |
|
Thank you Andrew @andrewserong ! Your feedback is much appreciated! |
|
Update: I'd still love for us to land a background image support feature. Now that this PR has become pretty stale and is now a fair way behind trunk, I'll close out this particular PR. If and when we wish to revisit the feature, we can borrow the ideas here and open up a new PR. |
1 task
|
Update: I've started a new WIP PR to explore a potential implementation for this over in #53934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚧 🚧 🚧 🚧 🚧 Note: this is an exploratory WIP PR that is likely to change 🚧 🚧 🚧 🚧 🚧
In this exploratory/experimental PR, we're looking at adding in a background image block support, that any block can opt-in to. In this exploration we're looking at the following:
styleattribute in abackgroundImagekeyTo do
Testing Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).