-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Background Tools" an easy API and add to Group / Columns #16479
Comments
When a background image is set as background, it would be nice if also the dominant image color is automatically set as background image. Then the element already got a good color while the image still loads and when images are disabled. |
I am going to remove needs design for now from this as both issues linked do have that and are in progress. |
@strarsis I think that's a wonderful idea!!! This suggestion inspired me to experiment and I think I have something pretty solid working <3 Video demo: |
Sorry if it's been already discussed but can the InspectorControls be grouped into a new component that could then be used consistently to provide backgrounds? And in situations where you might need to provide multiple backgrounds for 1 block (custom blocks might) then that component could be utilized again in multiple panels, like:
Any thoughts about using the same split as Elementor which is to define "Background Overlay" as separate from "Background"? |
Have started a discussion here about options for implementing this. |
@andrewserong since you self-assigned this issue recently: Is there any feature that you think could still land until Wednesday next week to be included in WordPress 6.0 release? To increase visibility, we can add it to the WordPress Editor 6.0 project board. |
Thanks for the ping @adamziel — I don't think there'll be anything to land in time for 6.0 from what I was exploring. I worked on a proof of concept for a background image block support in #39243 (comment) and we now have designs for a future direction for how the background controls might work (in #39427), but that will likely be a bigger piece of work for post 6.0. |
As this very ticket deals with the technical foundations for making more sophisticated background options (as of WP 6.2 only available in the Cover block) generally available for various blocks, especially for the Group block, I think this idea is worth sharing here: |
Wanted to note that this continues to come up around template parts, especially for a simple use case of wanting to have a background image in a header for example: #29238 This issue was closed but feedback was gathered for consideration. |
Closing as this is all done. |
As part of the effort to refine how we present and expose common block functionality (see #15450) we'll be both working on the technical infrastructure and the actual solutions. One of those is background tools. Right now it's possible to add video backgrounds, colored overlays, etc, to the Cover block alone. It'd make sense to extract this and extend to other container blocks (group and columns, for example) as well as expanding the features.
This ticket is meant to focus on the UI for background tools (toolbar and block inspector) and its feature set.
Tasks
Column
andGroup
. See Common Block Functionality #15450The text was updated successfully, but these errors were encountered: