Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve switch to draft button e2e test robustness #38971

Merged

Conversation

chad1008
Copy link
Contributor

Description

Follow up to #37491

This PR improves the XPath selector for the post scheduling calendar as discussed in #38717 (review) to add more specificity and make the test more robust.

cc @ciampo

Testing Instructions

all tests should pass

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ciampo ciampo self-requested a review February 22, 2022 07:46
@ciampo ciampo added [Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement. labels Feb 22, 2022
@chad1008 chad1008 merged commit 9c6e197 into WordPress:trunk Feb 24, 2022
@chad1008 chad1008 deleted the fix/improve-switch-to-draft-test-xpath branch February 24, 2022 14:42
@github-actions github-actions bot added this to the Gutenberg 12.8 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants