Post Visibility e2e test: Improve XPath selector to avoid reliance on DOM structure #38717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] E2E Tests
ciampo
reviewed
Feb 17, 2022
packages/e2e-tests/specs/editor/various/post-visibility.test.js
Outdated
Show resolved
Hide resolved
chad1008
force-pushed
the
fix/improve-post-visibility-test-xpath
branch
from
70b86d2 to
d23ed26
Compare
8 tasks
ciampo
approved these changes
Feb 22, 2022
chad1008
force-pushed
the
fix/improve-post-visibility-test-xpath
branch
from
d23ed26 to
a96b2af
Compare
|
rebased and passing! ✅ |
|
The CI failure (the Gradle cache can't be restored when running React Native E2E tests) doesn't seem related to the changes in this PR, I'm going to merge |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #37491 (comment), this PR modifies the XPath selector targeting a future date for the post's publication when running post visibility e2e tests. The new XPath makes the test more resilient by avoiding reliance on DOM structure which could change in the future.
Testing Instructions
From your local Gutenberg directory, run
npx wp-scripts test-e2e --config packages/e2e-tests/jest.config.js packages/e2e-tests/specs/editor/various/post-visibility.test.js. All tests should pass, specifically final test related to changing post visibility when the publication date is in the futurecc @ciampo
Types of changes
enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).