Update pagination icons, add new query title and post terms icons #38521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +548 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Feb 4, 2022
Regarding your comment in the issue the |
I blame that it's monday, but I can't for the life of me figure out how to get to this block. All I see are these: But with that beautiful green button glowing, I'm going to land this one as is, but I'm happy to follow up if you can share a screenshot or something. |
The Screen.Recording.2022-02-07.at.11.42.24.AM.mov |
|
Oh interesting, so it's more of a "meta"-block, in that it only ever shows up in global styles? In that case I wonder if we shouldn't just use one of the existing next/prev icons for that 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37541.
This adds a couple of new icons:
And updates from the latest in Figma a few existing ones:
37541 also details "Post Navigation Link", but I wasn't sure exaclty what that was. Can we just use "Post Navigation" for that?
Note also that the "numbers" icon appears to be unused, but is still in the package.
Pagination before and after:
Next/prev before and after:
Numbers after:
New Query icon shown in context of Post title in Figma:
Post terms in Figma:
Query title and post terms shown in "all blocks" context:
Testing Instructions
Open global styles, select "All blocks" and observe new icons for pagination, pagination next, pagination previous, query title, post terms.
Checklist:
*.native.jsfiles for terms that need renaming or removal).