Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles sidebar: Post terms, post navigation, and query title are missing icons #37541

Closed
carolinan opened this issue Dec 21, 2021 · 6 comments · Fixed by #38521
Closed
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress

Comments

@carolinan
Copy link
Contributor

Description

In the global styles sidebar in the site editor, these blocks are missing their custom icons. Instead, the "lego brick" is shown:
Post terms, post navigation, and query title.

Step-by-step reproduction instructions

  1. Activate a theme with support for full site editing
  2. Go to Appearance > Editor
  3. Open styles
  4. Select Blocks
  5. In the list of blocks, see the icons.

Screenshots, screen recording, code snippet

list of block names and icons

Environment info

WordPress 5.9-beta3-52379-src
With and without Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Dec 21, 2021
@carolinan
Copy link
Contributor Author

Perhaps the real question is if these blocks should be visible here or if their variations should be used?
(Archive title, next/previous, post categories, post tags)

@carolinan
Copy link
Contributor Author

Do you have any thoughts on this issue @jasmussen?

@jasmussen
Copy link
Contributor

Good ticket, thank you. It seems like the mini-icon with two rows of text below pattern used for the other related icons (post title, post excerpt etc) might work well here also. @javierarce since you created that excellent submenu icon yesterday, is this something you'd like to take a stab at? Otherwise I have some bandwidth to tackle this next week.

@javierarce
Copy link
Contributor

@jasmussen please, go for it if you have the time, I'm a bit swamped with work right now.

@jasmussen
Copy link
Contributor

Awesome, I'll take a stab, no worries 👌

@jasmussen
Copy link
Contributor

Took a stab in #38521. Note I wasn't able to find the "Post Navigation Link" to insert, and it's unclear to me what it does. Can we just use the existing Pagination icon for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants