Add automated RTL support #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to autogenerate RTL css files, so this won't be needed
This currently loads the version from https://github.com/yoavf/webpack-rtl-plugin/tree/develop This include a simple (but required) change, that's been requested upstream as a PR: romainberger/webpack-rtl-plugin#15
This is done by adding style data - WP will automatically load the -rtl css files instead of the regular files in RTL mode.
|
Whoa what serendipitous timing! CC @youknowriad 😉 |
|
Ha @jasmussen - I got started with this at WC US, and missed #3831 before pushing. I think this method is preferable, since we don't end up with big LTR and RTL css files, and we use WP's built in style loading for RTL. If there's ever a decision to switch to having the CSS inline, then using postcss makes more sense. |
youknowriad
approved these changes
Dec 7, 2017
gutenberg.php
Outdated
| @@ -484,7 +488,11 @@ function gutenberg_replace_default_add_new_button() { | |||
| display: block; | |||
| top: 0; | |||
| margin: -1px 0; | |||
| <?php if ( is_rtl() ) : ?> | |||
There was a problem hiding this comment.
Just wondering about the indentation here, should it be aligned with the styling (like above) or not? We should probably be consistent anyway.
|
This is absolutely the better approach! Thanks Yoav. |
|
Awesome work |
Closed
This was referenced Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current RTL experience with Gutenberg is broken, and there's no reason to try and maintain RTL css manually.
This adds automated generation of RTL CSS files using rtlcss via a slightly modified webpack-rtl-plugin. The modification to the plugin are described in this PR.
It also adds minor fixes for the new post button inline css.
How Has This Been Tested?
Confirmed that:
npm run buildwill also build-rtl.cssfiles.Screenshots (jpeg or gifs if applicable):
Before:
After:
Types of changes
Bug fix for current RTL CSS
Checklist: