Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta boxes arrow icons in RTL #1565

Closed
afercia opened this issue Jun 28, 2017 · 1 comment
Closed

Meta boxes arrow icons in RTL #1565

afercia opened this issue Jun 28, 2017 · 1 comment
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts

Comments

@afercia
Copy link
Contributor

afercia commented Jun 28, 2017

Many things still need to fully support RTL languages in the UI. One small detail is about the meta boxes icons.

They're currently using a right-arrow icon when collapsed and a down-arrow icon when expanded:

screen shot 2017-06-28 at 17 29 55

See also related discussion on Slack https://wordpress.slack.com/archives/C02QB2JS7/p1498468801241441?thread_ts=1498209002.818056&cid=C02QB2JS7

If the right-arrow icon is going to stay, I guess it should be swapped to left-icon for RTL languages. I think this is something WordPress does during the build process with a custom grunt plugin swap-dashicons-left-right-arrows. Instead, Gutenberg sets these icons in the component, depending on the meta box opened state:
icon={ this.state.opened ? 'arrow-down' : 'arrow-right' }

/cc @ocean90

@afercia afercia added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Jun 28, 2017
@jasmussen jasmussen self-assigned this Dec 5, 2017
@jasmussen
Copy link
Contributor

I built a fix for this one in #3831, which was then improved upon in #3844. As such, I'm closing this as fixed. Feel free to reopen if this was in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants