Add: Mechanism to keep styles during block transforms. #37596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +309 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/keep-styles-during-block-transforms
branch
2 times, most recently
from
db681e5 to
6032402
Compare
ntsekouras
reviewed
Dec 27, 2021
There was a problem hiding this comment.
Thanks for working on this Jorge!
The problem is more convoluted because we can transform multiple blocks at once and here we don't take account for that (take first block's attributes).. I haven't thought about that in depth but we should also consider any possible different handling between blocks that produce 1-1 transformations or create wrapper blocks with Innerblocks.
It reminds me actually the case of matching block patterns here.
I have a recording that shows the use case of multiselecting two paragraphs and shows the preview of transform to: Heading and Group
Screen.Recording.2021-12-27.at.7.05.13.PM.mov
jorgefilipecosta
force-pushed
the
add/keep-styles-during-block-transforms
branch
2 times, most recently
from
b7b4f99 to
54dfa35
Compare
|
Hi @ntsekouras, I expanded the logic to cover the cases you referred. It should now be working well on most of the cases. |
|
Hey Jorge! Do you think it's possible to integrate this functionality in |
Hi @ntsekouras,
Everything related to the styles is implemented as a block support hook, the styles are implemented as if they were plugins. Even adding style markup and classes is implemented as hook e.g: in https://raw.githubusercontent.com/WordPress/gutenberg/54dfa3527d9101dabb35cf6d630b6e25b809523c/packages/block-editor/src/hooks/color.js addSaveProps function. The UI is also implemented in the hook in ColorEdit. So our block API is not even aware of colors, typography etc. I think If everything related to this functionality is in the hook (the UI, the markup, etc) the way to deal with transforms should also be in the hook. If we add this to the block API we break the abstraction the API becomes aware of colors, typography, etc. So is the markup (the essential part) added as a hook and not directly in the engine if we add the transforms (which are less relevant) to the engine directly? |
Yes, you're right! It seems I rushed with my comment 😄 . I'll give a proper review first thing tomorrow morning. |
ntsekouras
reviewed
Jan 26, 2022
jorgefilipecosta
force-pushed
the
add/keep-styles-during-block-transforms
branch
from
54dfa35 to
6349892
Compare
ntsekouras
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Thanks @jorgefilipecosta!
I still think some e2e testing would be good though 😄
|
Thank you for the review @ntsekouras. I'm working on some end to end tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36745
This PR proposes a mechanism to keep block styles during transforms. The mechanism is applied for color and font-size if this PR is accepted the mechanism will be expanded into other styles where it makes sense.
How has this been tested?
I created a paragraph.
I added a custom text color.
I added a named background color, and a named link color.
I added a custom font size.
I converted the paragraph to a list and verified all the styles were kept.
I added another list item.
I selected a preset font size.
I converted the list to paragraphs and verified all the styles were kept.
I selected the paragraphs and converted back to a list and verified the styles persisted on the list.