Cover block: update Dimensions panel label to avoid duplicate #34102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Block] Cover
This was referenced Aug 17, 2021
ramonjd
added
the
Needs Copy Review
ramonjd
requested review from
stacimc,
jasmussen,
aaronrobertshaw,
andrewserong,
apeatling and
glendaviesnz
|
Size Change: -8 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
Thanks for tackling the challenge, definitely something we'll want to solve. @mtias came with a suggestion yesterday which might be relevant to this conversation, which is that spacing related tools like margin and padding might not be a good fit for a "Dimensions" panel after all. That in fact, maybe they should be part of another panel, either Layout or just keep Spacing. So that could be one part of the solution, move the margins and padding controls to a Layout panel. The other part is that the minimum height really is related to the dimensions panel so ideally we move it to that panel and make it on by default for the cover block. I can't think of a situation where a block would have both height and minimum height, so blocks would have to opt into one or the other as part of the dimensions panel. But both feel valid and are related to the block dimensions. What do you think? |
|
Thanks for highlighting the potential change in direction @jasmussen 👍
Given I made the recent changes to rebrand spacing support to dimensions, I'd be happy to take care of this. I'll comment to that effect on the linked issue. If we can make that change before the next release it will take the pressure off needing either to add |
Yes! That could also be alternative. Thanks also for alerting us. 🙇
Let us know where we can jump in to help with reviews. One of our four (?) approaches probably needs to land before release day. After that we'd hopefully have a bit of time to switch the Cover block over to the Dimensions ToolsPanel. Cheers! 👍 |
|
Hi @ramonjd — thanks for the the copy review ping. Removing copy duplication looks good to me. |
ramonjd
force-pushed
the
update/dimensions-panel-label
branch
from
82b1a25 to
7d01a37
Compare
|
We can close this if #34065 gets off the ground. |
…ch as padding, margin and, soon, height, width and minimum width. Because the Cover block currently has padding support and features its own custom Dimensions block, there are two "Dimensions" blocks. Until we can come up with an approach to replace the Cover block's existing Dimensions block, either by activating minimum heights block supports or via SlotFills or otherwise, let's update the copy to remove the duplicate labels.
ramonjd
force-pushed
the
update/dimensions-panel-label
branch
from
7d01a37 to
57b9b21
Compare
7 tasks
|
#34065 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dimensions panel is merged. 🎉
It includes controls such as padding, margin and, soon, height, width and minimum width.
The Cover block currently has padding support, so it now has a dimensions panel.
But it also features an existing dimensions block, under which it has a minimum height control.
All this means is that there are now two "Dimensions" blocks.
A couple of initiatives that address this issue are underway:
These are still in progress.
So until we can come up with a definitive approach to replace the Cover block's existing Dimensions block, either by activating minimum heights block supports or via SlotFills or otherwise, let's update the copy to remove the duplicate labels before the next release.
Dimensions has become... wait for it... Minimum height. I'm open to ideas :) We don't need to fret about finding an overarching term since the minimum height control will be shifted to the dimensions ToolsPanel.
❗ I've also included screenshots for an optional change to the mobile copy (but not the changes in code). The duplication does not affect mobile for now, but it's an open question as to whether we change it everywhere to remain consistent or to leave out mobile copy changes.
How has this been tested?
Eyeballing.
Screenshots
Desktop!
Mobile!
Types of changes
Copy changes.