Cover block: Unify dimensions panels #34008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -60 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
ramonjd
added
[Feature] Design Tools
|
The resizable component within the cover block coverts minimum height units to This makes sense since it's calculate the new value in based on the clientHeight of the resize element (in pixels). The Unit Control UI however doesn't check for unit changes in incoming values. cover-block-pixels.mp4I've started a PR to allow this: #34029 The Unit Control component itself is a new G2 component and therefore experimental. The tests also don't seem to be passing. Just documenting for now. If alternatives occur to me I'll round back here. |
When the block style attribute for min height is changed, the unit control needs to be told of the change in unit. This may occur when the resizable box handles in the cover block are dragged.
|
@aaronrobertshaw Thanks for the update in bfdfb8f This is a better approach by far for our purposes. I started at the lowest level and got stuck there 🤭 |
Removing minHeight and minHeight unit attrs
This was referenced Aug 12, 2021
ramonjd
force-pushed
the
add/minimum-height-block-support
branch
4 times, most recently
from
7f0884c to
480d908
Compare
|
In the interests of avoiding duplicate labels before the release, here's a copy update to the existing Cover block dimensions panel label |
ramonjd
force-pushed
the
add/minimum-height-block-support
branch
from
480d908 to
209dd1c
Compare
|
We can delay or close this if #34065 gets off the ground |
ramonjd
force-pushed
the
add/minimum-height-block-support
branch
from
209dd1c to
6341854
Compare
|
#34065 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
<ResizableCover />to the minHeight block supports. Because the Resizable cover switches to px units automatically, we might have to update the support hooks to handle this. At the moment the sidebar unit controls UI don't reflect the switch to pixelsDescription
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).