Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d5a9b1
We need to specify the padding-top property because Firefox doesn't r…
anton-vlasenko Aug 13, 2021
64f3809
Don't use Mozilla specific css hacks and just apply proper top and bo…
anton-vlasenko Aug 13, 2021
5f52f34
Let's use 8px (equal to the size of the grid unit) vs 10px (as sugges…
anton-vlasenko Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/widgets/src/blocks/legacy-widget/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
line-height: 1;
min-height: 30px;
padding-left: $grid-unit-10;
padding-top: $grid-unit * 1.25;
padding-bottom: $grid-unit * 1.25;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 10px? Maybe we can do 8px ($grid-unit) too?

Copy link
Contributor Author

@anton-vlasenko anton-vlasenko Aug 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that value (10px) is being used on the Widgets page.
In my opinion, we should use similar values for the same component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point me to the place it's used on the Widgets page? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on Appearance -> Widgets page. Sorry if it wasn't clear.
Just add a new (legacy) Navigation Menu widget.
Screenshot 2021-08-17 at 9 52 33

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but I think it's defined by the theme (twentytwentyone). You might see other values if switch to other themes.

Copy link
Contributor Author

@anton-vlasenko anton-vlasenko Aug 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it is. 8px vs 10px is not such a big difference.
I think we can use 8px as well.
Fixed in 5f52f34

}
select {
padding-left: $grid-unit-05;
Expand Down