Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

merged 3 commits into from
Aug 19, 2021

Commits on Aug 13, 2021

  1. We need to specify the padding-top property because Firefox doesn't r… 

    …ender text correctly inside the select element in the legacy menu widget.
    @anton-vlasenko
    anton-vlasenko committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    7d5a9b1 View commit details
    Browse the repository at this point in the history

  2. Don't use Mozilla specific css hacks and just apply proper top and bo… 

    …ttom margins.
    @anton-vlasenko
    anton-vlasenko committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    64f3809 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Let's use 8px (equal to the size of the grid unit) vs 10px (as sugges… 

    …ted by @kevin940726 in https://github.com/WordPress/gutenberg/pull/34076/files#r690137625)
    @anton-vlasenko
    anton-vlasenko committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5f52f34 View commit details
    Browse the repository at this point in the history