[Block Library - Columns] Fix deprecation caused when adding a column #32378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
youknowriad,
dcalhoun,
aristath,
gziolo,
ceyhun,
carolinan and
tellthemachines
|
Size Change: +4 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Hi, @ntsekouras For some reason, I'm not able to reproduce the original issue. But changes make sense to me. I also noticed that the column width setting supports different units. Is it okay to hardcode the only percentage here? |
|
Thanks for testing @Mamaduka !
Now if we add a column and all the existing columns have '%' or no width we set the width to number. On reload this deprecation occurs where adds the So I guess it's okay but would like some more eyes here. |
dcalhoun
reviewed
Jun 3, 2021
gziolo
approved these changes
Jun 10, 2021
aristath
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #27756
Testing instructions are on the issue.