Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns block: Adding a column creates deprecations in the saved content #27756

Closed
gziolo opened this issue Dec 16, 2020 · 0 comments · Fixed by #32378
Closed

Columns block: Adding a column creates deprecations in the saved content #27756

gziolo opened this issue Dec 16, 2020 · 0 comments · Fixed by #32378
Assignees
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Dec 16, 2020

Describe the bug

Discovered when testing #27681.

It was probably introduced in #24711.

There is this edge case when adding a new column in the Columns block updates child Column blocks with a number value for width attribute. In #24711 width was updated to work with percentage values (or strings? in general) so this triggers deprecation in the editor.

To reproduce
Steps to reproduce the behavior:

  1. Create a new Blog Post
  2. Add A Columns block
  3. Select 70/30
  4. Change column 1 to 90%
  5. Set Column 2 to 10% (or around there)
  6. Add the third column
  7. Save the post
  8. Refresh the page and observer JS consoler

Expected behavior

When the block is saved it uses with values for Column blocks that don't trigger deprecations.

Screenshots

Screen Shot 2020-12-16 at 13 33 01

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Block] Columns Affects the Columns Block labels Dec 16, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants