Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Bump Webpack dependency versions #2841

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 30, 2017

This pull request seeks to bump Webpack-related dependencies to their latest versions.

Relevant changelogs for versions introducing breaking changes:

Testing instructions:

Verify that npm run dev and npm run build complete with no errors.

Ensure that PostCSS configuration is still applied as expected, specifically in applying prefixes automatically. An example is to confirm that -webpack and -ms prefixes are applied to box-align properties on .editor-saved-state.

Ensure there are otherwise no regressions in the editor display.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Sep 30, 2017
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@aduth aduth merged commit d420547 into master Oct 2, 2017
@aduth aduth deleted the update/webpack-3-x branch October 2, 2017 12:17
@aduth
Copy link
Member Author

aduth commented Oct 3, 2017

Seems to be working happily enough, but I should have bumped the babel-loader dependency as well. It's currently warning on npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants