Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update dependencies to match the latest version of React #3107

Closed
gziolo opened this issue Oct 23, 2017 · 3 comments · Fixed by #3908
Closed

Framework: Update dependencies to match the latest version of React #3107

gziolo opened this issue Oct 23, 2017 · 3 comments · Fixed by #3908
Assignees
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@gziolo
Copy link
Member

gziolo commented Oct 23, 2017

Issue Overview

Raised by both @youknowriad and @aduth when upgrading React's version.

Reposting the comment from @aduth (#3079 (comment)):

Noting that many of our dependencies define a React peer in the 15.x line, so warnings are logged when installing a new version of a package:

npm WARN react-autosize-textarea@0.4.8 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-slot-fill@1.0.1 requires a peer of react@^15.5.8 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react@^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react-dom@^15.0.0 but none is installed. You must install peer dependencies yourself.

I imagine at least some of these should have updated versions available which define React 16 as a valid peer.

I noticed also another package babel-loader which expects an older version of Webpack.

I did some research already and here are my findings:

  • there are breaking changes introduced for react-transition-group. See Migration Guide from v1 to v2.
  • react-datepicker has peer dependency updated in the master branch, but they haven't been published as a new version yet. I'm anticipating to see them soon in the upcoming 0.57.0 version.

Expected Behavior

No warnings from npm install.

Current Behavior

npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-slot-fill@1.0.1 requires a peer of react@^15.5.8 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react@^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react-dom@^15.0.0 but none is installed. You must install peer dependencies yourself.
@gziolo gziolo added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take labels Oct 23, 2017
@aduth
Copy link
Member

aduth commented Oct 23, 2017

I noticed also another package babel-loader which expects an older version of Webpack.

This is not as much related to the React version bump as it was a Webpack version bump a few weeks back in #2841 (specifically #2841 (comment)).

@mtias
Copy link
Member

mtias commented Nov 20, 2017

@gziolo are you still looking at this?

@gziolo
Copy link
Member Author

gziolo commented Nov 20, 2017

react-transition-group is tricky to update because they changed public API, but I can tackle it this week.

@gziolo gziolo self-assigned this Dec 11, 2017
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants