Try: Use placeholder state to ensure legibility of quote block citation #26686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +81 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
6 tasks
|
I prefer the other one because there's a border on that Quote block that isn't visible at all with a dark theme. But it's there and takes up space, so I feel like it should be visible. PR #26684 solves that as well as the citation placeholder text. |
|
Closing in favor of #26684. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #26684, which is probably less impactful.
Changes the placeholder colors in quote block input fields, so that they are legible in themes that register themselves as dark:
We should only merge one of the two PRs. This one has the benefit of fixing the issue without changing any of the quote block CSS that is possibly in wide usage at the moment. The downside is, and as is also highlighted by the initial ticket, the opinionated styles for both quotes simply don't work very well in dark themes.