Try: Use currentColor to design quote blocks #26684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -90 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
This was referenced Nov 4, 2020
aristath
approved these changes
Nov 4, 2020
|
Kjell my friend, I know that this one has been by you in the past, and that we decided to shelve it. But I'm resurrecting it for two reasons:
It's also the cleanest way to address the various moving parts. Would love your thoughts once more if you have time. |
jasmussen
force-pushed
the
try/quotes-currentcolor
branch
from
762ee11 to
915e5bc
Compare
|
My concern is still just that this will change the display of quotes on the front-end of people's existing sites. 😕 Is it possible to make this change only when a dark theme is active? I'd feel a lot better about it then. Either way, as you noted this is a recurring issue. I think it might be worth trying this change out — we can always revert if it seems to be a problem for folks. |
|
Thank you for chiming in. The issue is that we can't know if a theme is dark or not on the frontend. There's no mechanism to discern that, and I don't think there will be. |
|
Ah that's right. I see what you mean. 😕 Then yeah, I say we go with option two: push this for now, revert/iterate later on if it's a problem. |
mapk
approved these changes
Nov 4, 2020
|
Let's try this, and I will revisit yet again if we get any issues. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes in #26510 and resurrects changes in #25358. It changes Quote and Pullquote blocks to use
currentColorto colorize both the content and citation fields, ensuring that it's legible in the editor, and on the frontend:There is also #26686 as an alternative to this one. The benefit of this PR is that it fixes both the issue with input field placeholder legibility, and also makes both quote blocks more useful in dark themes.