Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons Block: let icons wrap #25334

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Sep 15, 2020

Description

Fixes #24026

  • prevent overflowing by letting icons wrap
  • in editor prevent toolbar from jumping

How has this been tested?

  • Go to creating a new page
  • Create a 2-columns block, where the left column is smaller than the right
  • Add Social Icons block with 10 social icons in the left column
    Editor
  • Notice that all icons are clickable and icons tend to wrap to the next row
    Frontend
  • Notice that icons wrap to the next row instead of distorting

Screenshots

Icons not clickable

Before After
88240492-26d7c380-cc3c-11ea-8b74-0199316c0d1d SS 2020-09-15 at 14 55 18

Icons being distorted

Before After

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

cpap added 2 commits September 15, 2020 14:46
- prevent overflowing by wrapping
- in editor prevent toolbar from jumping
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a design perspective, it's working great and solves #24026. Thanks! 👍

social

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Tested and works as expected, fixes the issue.

@aristath aristath merged commit 15e2471 into WordPress:master Sep 16, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social icons are not clickable in 2-colons block
3 participants