-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social icons are not clickable in 2-colons block #24026
Comments
I agree with @mapk's suggestion. It follows suit with the navigation block, conforms to the space of the column and of course, improves usability and visual balance. Also, would like to see the block toolbar not be affected by the hover states of the icons, which you can see in the GIF under the "Recreated problem" section above (the toolbar bumps up and down slightly). Personally, it should keep a consistent distance at the top of the social icons block. I also noticed that on smaller resolutions/widths, the icons get improperly resized: |
@noahshrader the reason that toolbar jumps is because it's the toolbar for each individual social link block, so it moves to the particular social entity you're interacting with. If you click on the Social Links bock (the block that contains them all) the toolbar resides where it's expected to be. Also, good find 👍 on that other problem with resizing. |
@mapk Edited my prior post. What I'm referring to are the slight bumps with the block toolbar that happen when hovering over icons (because the hover states affect its position). To reproduce:
Curious if it would be cleaner for the block toolbar to be unaffected by the hover states of the icons and maintain a consistent Y position. |
Ah yes! Excellent. Thank you. 😄 |
It seems that all points are addressed here #25334 |
Describe the bug
The problem is if a have 2-columns block, where one of the columns is bigger than another one (one of the core templates of Gutenberg), social icons from block "social icons" which go over the column are not clickable, so I can't add a link to them anyway.
To reproduce
Steps to reproduce the behavior:
Screenshots
https://i.imgur.com/TI74yuO.jpg
Editor version (please complete the following information):
The text was updated successfully, but these errors were encountered: