CustomSelectControl: set aria-hidden to empty option list #21298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
[Focus] Accessibility (a11y)
Aljullu
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: +4 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
youknowriad
added
the
Good First Review
|
@Aljullu Thanks for working on this! I just tested it locally. Unfortunately, I did find an interaction issue :(. After selecting an item (keyboard or mouse), the focus doesn't return back to the Let me know if you're experiencing the same issue Thanks! |
Aljullu
changed the title
|
Oh, right, I completely missed that. Another approach I had in mind was to use |
Aljullu
force-pushed
the
fix/hide-empty-custom-select-control-list
branch
2 times, most recently
from
31a8712 to
7fdff59
Compare
Aljullu
force-pushed
the
fix/hide-empty-custom-select-control-list
branch
from
7fdff59 to
9281c52
Compare
|
I rebased this branch to fix the conflicts that have recently appeared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CustomSelectControlrenders the listbox containing the options even when the control is not open. That's causing Orca (Linux screen reader) to read Blank every time it's navigated through.In parallel, using an a11y audit tool like AXE, shows an error because of that:
This PR adds
aria-hidden={ true }to the options list when it's empty, so it's ignored by assistive technologies.How has this been tested?