Skip to content

Commit

Permalink
CustomSelectControl: set aria-hidden to empty option list (#21298)
Browse files Browse the repository at this point in the history
* CustomSelectControl: don't render option list if empty

* Render options list but use aria-hidden
  • Loading branch information
Aljullu authored Apr 30, 2020
1 parent daa2154 commit b4f0a07
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/components/src/custom-select-control/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export default function CustomSelectControl( {

const menuProps = getMenuProps( {
className: 'components-custom-select-control__menu',
'aria-hidden': ! isOpen,
} );
// We need this here, because the null active descendant is not
// fully ARIA compliant.
Expand Down

0 comments on commit b4f0a07

Please sign in to comment.