Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add docs for variations in the block registration section #20145

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Feb 10, 2020

@gziolo gziolo added [Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers labels Feb 10, 2020
@gziolo gziolo self-assigned this Feb 10, 2020
@gziolo gziolo mentioned this pull request Feb 14, 2020
23 tasks
@gziolo gziolo force-pushed the add/block-variation-docs branch 2 times, most recently from 797c78f to 2c7da08 Compare February 17, 2020 16:02
@gziolo gziolo marked this pull request as ready for review February 17, 2020 16:02
@gziolo gziolo force-pushed the add/block-variation-docs branch from 2c7da08 to 83b4c2e Compare February 17, 2020 16:09
@@ -71,7 +71,7 @@ import { DEPRECATED_ENTRY_KEYS } from './constants';
*
* @property {string} name The unique and machine-readable name.
* @property {string} title A human-readable variation title.
* @property {string} description A detailed variation description.
* @property {string} [description] A detailed variation description.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A description is optional, it was missed.

Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gziolo gziolo merged commit b19c663 into master Feb 18, 2020
@gziolo gziolo deleted the add/block-variation-docs branch February 18, 2020 20:46
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants