-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add docs for variations in the block registration section #20145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Feature] Block API
API that allows to express the block paradigm.
[Type] Developer Documentation
Documentation for developers
labels
Feb 10, 2020
16 tasks
mcsf
reviewed
Feb 11, 2020
docs/designers-developers/developers/block-api/block-registration.md
Outdated
Show resolved
Hide resolved
…ion.md Co-Authored-By: Miguel Fonseca <miguelcsf@gmail.com>
gziolo
force-pushed
the
add/block-variation-docs
branch
2 times, most recently
from
February 17, 2020 16:02
797c78f
to
2c7da08
Compare
gziolo
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
youknowriad
as code owners
February 17, 2020 16:02
gziolo
force-pushed
the
add/block-variation-docs
branch
from
February 17, 2020 16:09
2c7da08
to
83b4c2e
Compare
gziolo
commented
Feb 17, 2020
@@ -71,7 +71,7 @@ import { DEPRECATED_ENTRY_KEYS } from './constants'; | |||
* | |||
* @property {string} name The unique and machine-readable name. | |||
* @property {string} title A human-readable variation title. | |||
* @property {string} description A detailed variation description. | |||
* @property {string} [description] A detailed variation description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A description is optional, it was missed.
mcsf
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block API
API that allows to express the block paradigm.
[Type] Developer Documentation
Documentation for developers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #16283.
Preview:
https://github.com/WordPress/gutenberg/blob/5f311a633011616b41e97c848bdd75d06e6b520a/docs/designers-developers/developers/block-api/block-registration.md
Tutorials are going to be covered separately.