-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dimension controls to Group Block #16730
Commits on Feb 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1567db0 - Browse repository at this point
Copy the full SHA 1567db0View commit details -
Moves Dim Control to block editor package. Makes size class based rat…
…her than hard coded value
Configuration menu - View commit details
-
Copy full SHA for b072dd6 - Browse repository at this point
Copy the full SHA b072dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e75ac86 - Browse repository at this point
Copy the full SHA e75ac86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 851272d - Browse repository at this point
Copy the full SHA 851272dView commit details -
Addresses #16730 (comment) Renames `type` to `property` to better indicate that it is a formal CSS property value and therefore should not be translated lest it break the underlying code. Added title attribute to enable true text-based strings to be translatable.
Configuration menu - View commit details
-
Copy full SHA for e8ea617 - Browse repository at this point
Copy the full SHA e8ea617View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca7e68 - Browse repository at this point
Copy the full SHA cca7e68View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbd6cdb - Browse repository at this point
Copy the full SHA dbd6cdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0574e47 - Browse repository at this point
Copy the full SHA 0574e47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 672c51b - Browse repository at this point
Copy the full SHA 672c51bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d59d196 - Browse repository at this point
Copy the full SHA d59d196View commit details -
Configuration menu - View commit details
-
Copy full SHA for e63ed10 - Browse repository at this point
Copy the full SHA e63ed10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4babcb6 - Browse repository at this point
Copy the full SHA 4babcb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f26ad45 - Browse repository at this point
Copy the full SHA f26ad45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11b476c - Browse repository at this point
Copy the full SHA 11b476cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d92083 - Browse repository at this point
Copy the full SHA 7d92083View commit details -
Update to decouple DimensionControl component from knowledge of Block…
… attribute schema Previously the `DimensionControl` component manually constructed the attribute to be updated via string concatenation. This was brittle and prone to error and also couple the component to use in a Block context. Updated to utilise partial application to apply the dimension attribute argument in advance for each component. This allows us to simply the API of the component.
Configuration menu - View commit details
-
Copy full SHA for 45f7aa1 - Browse repository at this point
Copy the full SHA 45f7aa1View commit details -
Utilise withInstanceId HOC to remove need for id prop
Also updates tests to account for this.
Configuration menu - View commit details
-
Copy full SHA for d1b3aa8 - Browse repository at this point
Copy the full SHA d1b3aa8View commit details -
Updates size buttons for improved comprehension and a11y
Updates `N` to be `No`. Also avoids string manipulation approach to getting visual size button label in favour of explicit abbr prop on sizes.
Configuration menu - View commit details
-
Copy full SHA for 5d5d198 - Browse repository at this point
Copy the full SHA 5d5d198View commit details -
Configuration menu - View commit details
-
Copy full SHA for d30b760 - Browse repository at this point
Copy the full SHA d30b760View commit details -
Configuration menu - View commit details
-
Copy full SHA for f94a15e - Browse repository at this point
Copy the full SHA f94a15eView commit details -
Remove duplicate Dimension Control
This was handled in a separate PR and resides in `@wordpress/components`. Can be removed from this PR.
Configuration menu - View commit details
-
Copy full SHA for 28ca9b4 - Browse repository at this point
Copy the full SHA 28ca9b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d41a49 - Browse repository at this point
Copy the full SHA 8d41a49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9923154 - Browse repository at this point
Copy the full SHA 9923154View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc3277b - Browse repository at this point
Copy the full SHA cc3277bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad7325b - Browse repository at this point
Copy the full SHA ad7325bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 325c45a - Browse repository at this point
Copy the full SHA 325c45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d1dee - Browse repository at this point
Copy the full SHA 08d1deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f9579a - Browse repository at this point
Copy the full SHA 3f9579aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4095617 - Browse repository at this point
Copy the full SHA 4095617View commit details -
Configuration menu - View commit details
-
Copy full SHA for e200219 - Browse repository at this point
Copy the full SHA e200219View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44575ec - Browse repository at this point
Copy the full SHA 44575ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 223ee9a - Browse repository at this point
Copy the full SHA 223ee9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd3741f - Browse repository at this point
Copy the full SHA fd3741fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c96458 - Browse repository at this point
Copy the full SHA 3c96458View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad9c74 - Browse repository at this point
Copy the full SHA 9ad9c74View commit details -
Configuration menu - View commit details
-
Copy full SHA for e849702 - Browse repository at this point
Copy the full SHA e849702View commit details -
Configuration menu - View commit details
-
Copy full SHA for af88337 - Browse repository at this point
Copy the full SHA af88337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f516ae - Browse repository at this point
Copy the full SHA 3f516aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7678379 - Browse repository at this point
Copy the full SHA 7678379View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9bed02 - Browse repository at this point
Copy the full SHA a9bed02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6eec9 - Browse repository at this point
Copy the full SHA 0a6eec9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cec67bf - Browse repository at this point
Copy the full SHA cec67bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6ec10c - Browse repository at this point
Copy the full SHA f6ec10cView commit details