Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Adding a label to the edit image buttons #1669

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

youknowriad
Copy link
Contributor

closes #1664

Sorry for missing that the first time :)

@youknowriad youknowriad added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 3, 2017
@youknowriad youknowriad self-assigned this Jul 3, 2017
@youknowriad youknowriad requested a review from afercia July 3, 2017 14:58
@afercia
Copy link
Contributor

afercia commented Jul 3, 2017

@youknowriad thanks! Not sure if we want to use the article the. Maybe better just Edit image?

@youknowriad
Copy link
Contributor Author

@afercia Works for me.

Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor consideration about the label wording.

@youknowriad youknowriad force-pushed the update/label-edit-image-button branch from 93ad3d5 to 73ef120 Compare July 3, 2017 15:10
@youknowriad youknowriad merged commit 1fd55b2 into master Jul 3, 2017
@youknowriad youknowriad deleted the update/label-edit-image-button branch July 3, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The edit image button for the image and cover image blocks needs to be labeled
2 participants