Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The edit image button for the image and cover image blocks needs to be labeled #1664

Closed
afercia opened this issue Jul 3, 2017 · 0 comments · Fixed by #1669
Closed

The edit image button for the image and cover image blocks needs to be labeled #1664

afercia opened this issue Jul 3, 2017 · 0 comments · Fixed by #1669
Assignees
@youknowriad
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jul 3, 2017

See #1459

The edit image and edit cover image buttons need an aria-label attribute.

screen shot 2017-07-03 at 15 21 55

Currently they're just empty buttons and there's nothing assistive technologies can announce. Example of the current rendered markup:

<button type="button" class="components-button components-icon-button components-toolbar__control">
	<svg aria-hidden="true" role="img" ... ></svg>
</button>
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 3, 2017
@youknowriad youknowriad self-assigned this Jul 3, 2017
@youknowriad youknowriad mentioned this issue Jul 3, 2017
Merged
@afercia afercia mentioned this issue Sep 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accessibility: Adding a label to the edit image buttons WordPress/gutenberg
2 participants
@youknowriad @afercia