Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Picker and BottomSheet to the @wordpress/components package #15750

Merged
merged 1 commit into from
May 23, 2019
Merged

Move Picker and BottomSheet to the @wordpress/components package #15750

merged 1 commit into from
May 23, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented May 21, 2019 •
edited
Loading

Description

This PR is the first change for wordpress-mobile/gutenberg-mobile#958
It moves 2 native mobile components from the @wordpress/block-editor package to the @wordpress/components one so we can reuse them from other packages and avoid circular dependencies.

How has this been tested?

Test with wordpress-mobile/gutenberg-mobile#1008

Screenshots

Types of changes

Mobile components refactoring

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 21, 2019
@Tug Tug requested review from koke and etoledom May 21, 2019 09:21
@Tug Tug self-assigned this May 21, 2019
@Tug Tug mentioned this pull request May 21, 2019
Closed
8 tasks
@koke koke mentioned this pull request May 22, 2019
Closed
10 tasks
@Tug Tug mentioned this pull request May 22, 2019
Merged
@Tug Tug force-pushed the rnmobile/add/bottom-sheet-and-picker-components branch from ddb122b to 30883fa Compare May 22, 2019 18:04
@Tug Tug removed the [Status] In Progress Tracking issues with work in progress label May 22, 2019
@Tug Tug marked this pull request as ready for review May 22, 2019 18:27
etoledom
etoledom approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good! 🎉
Thank you @Tug for improving this.

@Tug Tug merged commit e3afe62 into master May 23, 2019
@Tug Tug deleted the rnmobile/add/bottom-sheet-and-picker-components branch May 23, 2019 09:25
@youknowriad youknowriad added this to the 5.8 (Gutenberg) milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@koke koke Awaiting requested review from koke

Assignees

@Tug Tug

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.8 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@Tug @etoledom @youknowriad