Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Master thread: Native support for inner blocks #15749

Closed
1 of 8 tasks
Tug opened this issue May 21, 2019 · 3 comments
Closed
1 of 8 tasks

[RNMobile] Master thread: Native support for inner blocks #15749

Tug opened this issue May 21, 2019 · 3 comments
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Milestone

Comments

@Tug
Copy link
Contributor

Tug commented May 21, 2019

In previous efforts we tried to port the BlockManager and related components from the Gutenberg mobile repository to the Gutenberg repository, to pave the way for inner blocks on RN mobile. However that prove to be unsuccessful as the PR was getting too big to review at once.

To give more context, BlockManager is the equivalent of BlockList and it depends on many components that still lives in the gutenberg-mobile repo.
The goal here will be to make that port so that we can ultimately have BlockList be reused from the gutenberg repository in components such as InnerBlock.

This issue will serve as a reference for this task and will help monitor the progress on the different PRs.

  • 1. Move BottomSheet and Picker to @wordpress/components make them available from outside the block-editor package (GB PR#15750 and GB-Mobile PR#1008)
  • 2. Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to gutenberg so we can reuse those from there
  • 3. Inserter ported from BlockPicker
  • 4. BlockInspector ported from InlineToolbar
  • 5. BlockToolbar ported from BlockToolbar
  • 6. BlockListBlock ported from BlockHolder
  • 7. BlockList ported from BlockManager
  • 8. Create a native version of InnerBlock

cc @koke @hypest @daniloercoli @gziolo

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 21, 2019
@Tug Tug added this to the Future milestone May 21, 2019
@Tug Tug self-assigned this May 21, 2019
@hypest
Copy link
Contributor

hypest commented May 21, 2019

I personally like the approach portrayed in this new ticket better, which is to port the deeper/smaller/more-leafy components first and then move up the dependency tree. I've been advocating for that in the past, though I understand it's not easy to validate unless one tries the "big" approach first. I'm optimistic about this new approach! 👐

@koke
Copy link
Contributor

koke commented May 22, 2019

Is this replacing wordpress-mobile/gutenberg-mobile#958 then? I don't mind if you prefer tracking progress here, but please make sure the project has the right issue in the right place.

@Tug
Copy link
Contributor Author

Tug commented May 22, 2019

Sorry @koke I forgot about the issue you created and made another one here. I agree we can close this one then 👍

@Tug Tug closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

No branches or pull requests

3 participants