Expose position prop in DotTip component

[HardeepAsrani]

Description

This will expose the position prop in DotTip component which uses Popove component internally to make the popover.

How has this been tested?

It was tested with the default DotTip that are being used for NUX. It's worth mentioning that the positioning will only take place if space is available for it (it drove me mad because I thought it wasn't working).

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

Fixes #14923

[aduth]

I might like to know if there was some design rationale from the original implementation (#6631, #3670) for which the position would have been hard-coded. Adding "Needs Design Feedback".

[karmatosed]

I have done some digging into this and the reasoning isn't clear so I think based on that it should be likely to work exposing. I will cc in @noisysocks also as one of the originators of a lot of Tips code.

[noisysocks]

I have done some digging into this and the reasoning isn't clear so I think based on that it should be likely to work exposing. I will cc in @noisysocks also as one of the originators of a lot of Tips code.

The rationale was that I didn't need it so I didn't add it! 😀

It's worth mentioning that the positioning will only take place if space is available for it (it drove me mad because I thought it wasn't working).

This has bitten me before too! 😂

[noisysocks]

You could do this with a default argument if you want to make it more explicit that the argument is optional.

export function DotTip( {
	position = 'middle right',
	...
} ) {
	...

Totally up to you, though!

[aduth]

You could do this with a default argument if you want to make it more explicit that the argument is optional.

I'd agree this would probably be the best way to communicate it as an optional prop, and it may help future maintainability if there are changes to the component which reference position in more than this one location.

[HardeepAsrani]

@aduth Should I make this change then?

[aduth]

@aduth Should I make this change then?

It would be a worthwhile improvement if you're willing, yes.

[HardeepAsrani]

@aduth Made the changes. :)

[noisysocks]

Thanks @HardeepAsrani!