Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUX DotTip Positioning #14923

Closed
HardeepAsrani opened this issue Apr 11, 2019 · 2 comments · Fixed by #14972
Closed

NUX DotTip Positioning #14923

HardeepAsrani opened this issue Apr 11, 2019 · 2 comments · Fixed by #14972
Labels
[Feature] NUX Anything that impacts the new user experience

Comments

@HardeepAsrani
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I was making a custom NUX for a project using DotTip from Gutenberg but the positioning is always middle right always which makes it a bit frustrating.

Describe the solution you'd like
Popover component already has a position prop that we just need to expose.

PR coming.
@HardeepAsrani
Copy link
Contributor Author

Forgot to make this into a PR. 😄

@HardeepAsrani
Copy link
Contributor Author

PR: #14972

@swissspidy swissspidy added the [Feature] NUX Anything that impacts the new user experience label Apr 21, 2019
@HardeepAsrani HardeepAsrani mentioned this issue Apr 21, 2019
Merged
5 tasks
@kjellr kjellr mentioned this issue Jun 26, 2019
Closed
noisysocks pushed a commit that referenced this issue Jul 11, 2019
@HardeepAsrani @noisysocks
Expose position prop in DotTip component (#14972)
99a7eb4 
* Add position prop to DotTip

Added `position` prop to DotTip component. Closes #14923

* Update index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] NUX Anything that impacts the new user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose position prop in DotTip component
2 participants
@swissspidy @HardeepAsrani